Skip to content

[stable16] Lock SCSS so we only run 1 job at a time - #16541

Merged
rullzer merged 1 commit into
stable16from
backport/15794/stable16
Jul 25, 2019
Merged

[stable16] Lock SCSS so we only run 1 job at a time#16541
rullzer merged 1 commit into
stable16from
backport/15794/stable16

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Jul 25, 2019

Copy link
Copy Markdown

backport of #15794

@rullzerBackportbot
Lock SCSS so we only run 1 job at a time
3f5ce65
This is bit hacky but a start to lock the SCSS compiler properly
Retry during 10s then give up
Properly get error message
Do not clear locks and properly debug scss caching
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 16.0.4 milestone Jul 25, 2019
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 25, 2019
Merged
2 tasks
MorrisJobke
MorrisJobke approved these changes Jul 25, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

rullzer
rullzer approved these changes Jul 25, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this

@rullzerrullzer added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 25, 2019
@rullzer
rullzer merged commit 540168f into stable16Jul 25, 2019
@delete-merged-branch
delete-merged-branchBot deleted the backport/15794/stable16 branch July 25, 2019 17:40
@rullzerrullzer mentioned this pull request Aug 7, 2019
Merged
2 tasks
@rullzerrullzer mentioned this pull request Sep 12, 2019
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@icewind1991icewind1991Awaiting requested review from icewind1991
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbughigh

Projects

None yet

Milestone

Nextcloud 16.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv