Skip to content

Set proper defaults for v-tooltip usages - #16596

Merged
rullzer merged 2 commits into
masterfrom
bugfix/noid/vtooltip-defaults
Jul 30, 2019
Merged

Set proper defaults for v-tooltip usages#16596
rullzer merged 2 commits into
masterfrom
bugfix/noid/vtooltip-defaults

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jul 29, 2019

Copy link
Copy Markdown
Member

No description provided.

@juliusknorrjuliusknorr added 3. to review Waiting for reviews bug labels Jul 29, 2019
MorrisJobke
MorrisJobke approved these changes Jul 29, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 29, 2019
@MorrisJobkeMorrisJobke added this to the Nextcloud 17 milestone Jul 29, 2019
@juliusknorr

juliusknorr commented Jul 29, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@juliusknorr

juliusknorr commented Jul 29, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@juliusknorrjuliusknorr added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jul 29, 2019
@juliusknorr

juliusknorr commented Jul 29, 2019

Copy link
Copy Markdown
MemberAuthor

Needs another fix in the settings app

@juliusknorr
Force defaultHtml setting of v-tooltip to be disabled
3d6e49a
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump bundles
09b5df4
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the bugfix/noid/vtooltip-defaults branch from ba1cd4b to 09b5df4CompareJuly 29, 2019 18:38
@juliusknorr

juliusknorr commented Jul 29, 2019

Copy link
Copy Markdown
MemberAuthor

Done, settings needed to be specified with Vue.use(VTooltip, { defaultHtml: false }) instead of overwriting the options default, since they use the provided vue plugin instead of the directive.

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 29, 2019
@rullzer
rullzer merged commit fc497eb into masterJul 30, 2019
@delete-merged-branch
delete-merged-branchBot deleted the bugfix/noid/vtooltip-defaults branch July 30, 2019 06:43
@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 30, 2019

Copy link
Copy Markdown

The backport to stable16 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 30, 2019

Copy link
Copy Markdown

The backport to stable15 failed. Please do this backport manually.

This was referenced Jul 30, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@nickvergessen@MorrisJobke@rullzer