Uh oh!
There was an error while loading. Please reload this page.
workflow overhaul - #16682
Conversation
Spartachetto
commented
Aug 11, 2019
Could this be used to implement #1291? |
blizzz
commented
Aug 12, 2019
@Spartachetto Yes, totally! |
5f95c33 to
62ab277Compare| new GenericEntityEmitterEvent($emitterClass, $slot, 'postWrite', $this->l10n->t('File updated')), | ||
| new GenericEntityEmitterEvent($emitterClass, $slot, 'postRename', $this->l10n->t('File renamed')), | ||
| new GenericEntityEmitterEvent($emitterClass, $slot, 'postDelete', $this->l10n->t('File deleted')), | ||
| new GenericEntityEmitterEvent($emitterClass, $slot, 'postTouch', $this->l10n->t('File accessed')), |
There was a problem hiding this comment.
Shouldn't this be preRead or is the touch happening before the file is actually read?
There was a problem hiding this comment.
Ah no this will be using an IFixedEventListener, but we should make sure we still have an event definition exposed for those cases to the frontend.
There was a problem hiding this comment.
The original idea was that for special edge cases, the operators take care of listening to the right hooks and doing the right things (wrapper). But you're right, we need to present it somehow.
cb4bd79 to
9d9a333CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
700c038 to
ae2bf15Compare
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
c1b5bbd to
6c75aa4Compare
This comment has been minimized.
This comment has been minimized.
ce12c14 to
3714965CompareSigned-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Workflow frontend overhaul
| <name>Nextcloud workflow engine</name> | ||
| <summary>Nextcloud workflow engine</summary> | ||
| <description>Nextcloud workflow engine</description> | ||
| <version>1.8.0</version> |
rullzer
left a comment
There was a problem hiding this comment.
Some quick smoke testing tells me lets do this.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
for #12790
What I have discussed today with @juliushaertl to support the frontend/design concept.
Basics
Good to have
(internal) Vocabulary
App modifications
The list does not claim to be complete. The more we dig, the more comes to our mind…