Skip to content

Allow Context subclasses in acceptance tests to access parent actor - #16756

Merged
rullzer merged 1 commit into
masterfrom
allow-context-subclasses-in-acceptance-tests-to-access-parent-actor
Aug 18, 2019
Merged

Allow Context subclasses in acceptance tests to access parent actor#16756
rullzer merged 1 commit into
masterfrom
allow-context-subclasses-in-acceptance-tests-to-access-parent-actor

Conversation

@danxuliu

Copy link
Copy Markdown
Member

Although uncommon, in some cases a Context may need to be extended (for example, to override a step defined in the server with a specific behaviour in the acceptance tests of an app); in those cases the subclass should be able to access the actor attribute defined in the Context it is extending.

Although uncommon, in some cases a Context may need to be extended (for
example, to override a step defined in the server with a specific
behaviour in the acceptance tests of an app); in those cases the
subclass should be able to access the actor attribute defined in the
Context it is extending.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliudanxuliu added the 3. to review Waiting for reviews label Aug 16, 2019
@danxuliudanxuliu added this to the Nextcloud 17 milestone Aug 16, 2019
@rullzer
rullzer merged commit 08a61f3 into masterAug 18, 2019
@rullzer
rullzer deleted the allow-context-subclasses-in-acceptance-tests-to-access-parent-actor branch August 18, 2019 18:20
@rullzerrullzer mentioned this pull request Aug 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danxuliu@rullzer@skjnldsv