Stop if there is no encrypted token

[kesselb]

Fix#16729

Argument 1 passed to OC\Security\Crypto::decrypt() must be of the type string, null given

[rullzer]

Makes sense.

[kesselb]

Looks unrelated to me.

server/tests/Core/Controller/LostControllerTest.php

Lines 703 to 715 in 08a61f3

	$user = $this->createMock(IUser::class);
	$user->expects($this->any())
	->method('isEnabled')
	->willReturn(false);
	$user->expects($this->never())
	->method('setPassword');
	$this->config->method('getUserValue')
	->with('ValidTokenUser', 'core', 'lostpassword', null)
	->willReturn('encryptedData');
	$this->userManager->method('get')
	->with('DisabledUser')
	->willReturn($this->existingUser);

We should return $user instead of $this->existingUser here. Not sure why this is going to break now 🙈

[rullzer]

O lol. So the test was wrong. We just never noticed because we catched \Exception.
Good stuff

[blizzz]

looks good to me

[rullzer]

/backport to stable16

[backportbot-nextcloud]

backport to stable16 in #17648

[solracsf]

@kesselb still facing same issue on NC 17.0.2.

[cron] Error: TypeError: Argument 1 passed to OC\Security\Crypto::decrypt() must be of the type string, bool given,
called in /srv/lib/private/Security/IdentityProof/Manager.php on line 113 at <<closure>>
0. /srv/lib/private/Security/IdentityProof/Manager.php line 113
OC\Security\Crypto->decrypt("*** sensitive parameters replaced ***")
1. /srv/lib/private/Security/IdentityProof/Manager.php line 130
OC\Security\IdentityProof\Manager->retrieveKey("user-u221218")
2. /srv/lib/private/Security/IdentityProof/Signer.php line 62
OC\Security\IdentityProof\Manager->getKey(OC\User\User {})
3. /srv/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php line 142
OC\Security\IdentityProof\Signer->sign("lookupserver", {federationId: " ... "}, OC\User\User {})
4. /srv/lib/public/BackgroundJob/Job.php line 77
OCA\LookupServerConnector\BackgroundJobs\RetryJob->run({userId: "u221218"})
5. /srv/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php line 105
OCP\BackgroundJob\Job->execute(OC\BackgroundJob\JobList {}, OC\Log {})
6. /srv/cron.php line 124
OCA\LookupServerConnector\BackgroundJobs\RetryJob->execute(OC\BackgroundJob\JobList {}, OC\Log {})

[kesselb]

still facing same issue on NC 17.0.2.

Trace is different to: #16729 (comment). Please create a new issue.