Skip to content

Remove orphaned calendar data from deleted subscriptions - #16835

Merged
rullzer merged 2 commits into
masterfrom
bugfix/16833/remove-orphan-event-data-from-subscriptions
Sep 4, 2019
Merged

Remove orphaned calendar data from deleted subscriptions#16835
rullzer merged 2 commits into
masterfrom
bugfix/16833/remove-orphan-event-data-from-subscriptions

Conversation

@tcitworld

@tcitworldtcitworld commented Aug 22, 2019

Copy link
Copy Markdown
Member

Closes#16833. Ref #13511

@tcitworldtcitworld added 3. to review Waiting for reviews bug labels Aug 22, 2019
@tcitworld
Remove orphaned calendar data from deleted subscriptions
456fb7e
Closes#16833. Ref #13511
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld

tcitworld commented Aug 22, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

On my production database, 6M rows of calendarobjects, and 14M rows of calendarchanges are affected.
Didn't add the proper check, nothing affected. 🙈

tcitworld
tcitworld commented Aug 22, 2019
View reviewed changes
Comment threadapps/dav/lib/Migration/RemoveOrphanEventsAndContacts.php Outdated
@tcitworld
tcitworldforce-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch from 5b1f59c to 456fb7eCompareAugust 22, 2019 10:27
nickvergessen
nickvergessen requested changes Aug 22, 2019
View reviewed changes
Comment threadapps/dav/lib/Migration/RemoveOrphanEventsAndContacts.php
nickvergessen
nickvergessen reviewed Aug 22, 2019
View reviewed changes
Comment threadapps/dav/lib/Migration/RemoveOrphanEventsAndContacts.php Outdated
@tcitworld
tcitworldforce-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch 2 times, most recently from a66b946 to 7624322CompareAugust 23, 2019 13:13
georgehrke
georgehrke reviewed Aug 26, 2019
View reviewed changes
Comment threadapps/dav/lib/Migration/RemoveOrphanEventsAndContacts.php Outdated
@georgehrke

georgehrke commented Aug 26, 2019

Copy link
Copy Markdown
Member

Otherwise this looks like a reasonable change to me 👍

@tcitworld
Check the calendar type of calendarobjects & calendarchanges
e2b539b
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the bugfix/16833/remove-orphan-event-data-from-subscriptions branch from 7624322 to e2b539bCompareAugust 26, 2019 08:42
@nickvergessen

nickvergessen commented Aug 26, 2019

Copy link
Copy Markdown
Member

/backport to stable16

@BernieO

BernieO commented Aug 26, 2019

Copy link
Copy Markdown
Contributor

Thanks for addressing this (#16833) so quickly 👍

Could this also be backported to stable15? Caching webcal calendars was introduced in NC15. So it would definitely make sense to backport it also to NC15

@tcitworldtcitworld added this to the Nextcloud 17 milestone Aug 28, 2019
@rullzerrullzer mentioned this pull request Aug 29, 2019
Merged
16 tasks
@rullzer
rullzer merged commit 0e19e55 into masterSep 4, 2019
@rullzer
rullzer deleted the bugfix/16833/remove-orphan-event-data-from-subscriptions branch September 4, 2019 08:54
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 4, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 4, 2019

Copy link
Copy Markdown

backport to stable16 in #16994

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@georgehrkegeorgehrkegeorgehrke approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

remove orphaned events also from deleted webcal calendars

5 participants

@tcitworld@georgehrke@nickvergessen@BernieO@rullzer