Skip to content

Fix SMB availability status + higher delay on auth issues - #16836

Merged
rullzer merged 3 commits into
masterfrom
fix/16724/smb-availability
Sep 9, 2019
Merged

Fix SMB availability status + higher delay on auth issues#16836
rullzer merged 3 commits into
masterfrom
fix/16724/smb-availability

Conversation

@blizzz

@blizzzblizzz commented Aug 22, 2019

Copy link
Copy Markdown
Member

Contains two fixes:
1.) sets unavailbility flag properly for SMB via php-smbclient
2.) adds a higher delay on auth issues to make a lock out on AD more unlikely

fixes#16724

@blizzz
catch auth issues also when php-smbclient is in use
cd62b38
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
set a storage availability delay on auth issues to avoid lock out
43bc31b
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 17 milestone Aug 22, 2019
@blizzz

blizzz commented Aug 22, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@blizzz

blizzz commented Aug 22, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable15

@blizzzblizzz changed the title Fix/16724/smb availabilityFix SMB availability status + higher delay on auth issuesAug 22, 2019
@rullzerrullzer mentioned this pull request Aug 23, 2019
Merged
@kesselbkesselb mentioned this pull request Aug 25, 2019
Closed
@blizzz
adjust tests
4bd83c9
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@kesselbkesselb mentioned this pull request Aug 27, 2019
Closed
@rullzerrullzer mentioned this pull request Aug 29, 2019
Merged
16 tasks
rullzer
rullzer approved these changes Aug 30, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. But I have no SMB setup to test against

@blizzz

blizzz commented Aug 30, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I got positive feedback from a customer, apart form a possible side effect:

One strange thing I've observed on my environment (nc 16.0.4 with your patch). When I create one new external storage mount with the webinterface its creates three mount points all with the same settings?

I'll try to reproduce it., but might be early next week if not today.

Therefore setting label to "developing".

@blizzzblizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 30, 2019
@blizzz

blizzz commented Sep 4, 2019

Copy link
Copy Markdown
MemberAuthor

I'll try to reproduce it., but might be early next week if not today.

Nope, WFM.

@blizzzblizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 4, 2019
@rullzerrullzer modified the milestones: Nextcloud 17, Nextcloud 18Sep 5, 2019
@rullzer

rullzer commented Sep 5, 2019

Copy link
Copy Markdown
Member

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

@blizzz

blizzz commented Sep 6, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@rullzer
rullzer merged commit bf6082e into masterSep 9, 2019
@rullzer
rullzer deleted the fix/16724/smb-availability branch September 9, 2019 14:50
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 9, 2019

Copy link
Copy Markdown

backport to stable16 in #17070

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 9, 2019

Copy link
Copy Markdown

backport to stable15 in #17071

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 9, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 9, 2019

Copy link
Copy Markdown

backport to stable17 in #17072

@joshtrichardsjoshtrichards mentioned this pull request Jun 19, 2026
Open
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@icewind1991icewind1991icewind1991 approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: external storage

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

external storage locks user in AD when password has changed in AD

3 participants

@blizzz@rullzer@icewind1991