Uh oh!
There was an error while loading. Please reload this page.
Only run integration tests when PHP was modified - #16879
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsv
commented
Aug 27, 2019
Nice idea!! |
kesselb
commented
Aug 27, 2019
Integration tests are not relevant for pull requests like #16798? |
skjnldsv
commented
Aug 27, 2019
no, they're only testing apis :) |
nickvergessen
commented
Aug 27, 2019
No, integration tests make API calls only. No JS or browser involved. |
kesselb
commented
Aug 27, 2019
Thank you for explaining 👍 |
blizzz
commented
Aug 27, 2019
Mh, do I understand correctly, you want to run them only after a PR was merged? |
skjnldsv
commented
Aug 27, 2019
No, only if the commits include changes on a php file, an integration test or if it's a merge commit! :) |
nickvergessen
commented
Aug 27, 2019
What @skjnldsv said. We do it like that since some weeks in Talk and it helped to improve the queue timers for JS/CSS only changes quite a lot. Now server is the biggest time drain and at least for pushes to JS/CSS only changes it is unnecessary to repeatedly check the integration tests. Merge commits always run the integration tests on master/stableX afterwards |
rullzer
commented
Aug 27, 2019
Could probably do the same on all the DB runs right? |
nickvergessen
commented
Aug 27, 2019
The time gain there is not a lot, but yeah. Anyway lets start like this and see how it works out. |
kesselb
commented
Aug 27, 2019
We could replace the default clone step with a custom one (https://docs.drone.io/user-guide/pipeline/cloning/#custom-logic) like for the submodules and run the check there. Benefits:
|
rullzer
commented
Aug 28, 2019
/backport to stable16 |
backport to stable16 in #16909 |
Integration tests are now only run when:
build/integrationwas modified