Uh oh!
There was an error while loading. Please reload this page.
Always use the folder icon depending on the mount type if not a share mount - #16976
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, danxuliu, rullzer and skjnldsvSeptember 3, 2019 08:21
juliusknorr
commented
Sep 3, 2019
MemberAuthor
/backport to stable16 |
skjnldsv
approved these changes
Sep 3, 2019
juliusknorr
commented
Sep 3, 2019
MemberAuthor
Pushed a fixup to still handle folders without a mountType properly |
rullzer
approved these changes
Sep 3, 2019
juliusknorrforce-pushed
the
bugfix/noid/directory-icon-mount
branch
from
September 3, 2019 14:09
c6b1853 to
62f543fComparerullzer
commented
Sep 4, 2019
Member
Needs a rebase |
juliusknorrforce-pushed
the
bugfix/noid/directory-icon-mount
branch
from
September 4, 2019 10:03
62f543f to
e711155Comparerullzer
commented
Sep 5, 2019
Member
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
rullzer
commented
Sep 7, 2019
Member
jsunit fails |
juliusknorrforce-pushed
the
bugfix/noid/directory-icon-mount
branch
from
September 12, 2019 13:16
e711155 to
1ac022aComparejuliusknorr
commented
Sep 12, 2019
MemberAuthor
Tried a different approach that also fixes the icon being correctly shown in the sidebar. At least the affected jsunit tests run fine locally now. Let'see. |
juliusknorrforce-pushed
the
bugfix/noid/directory-icon-mount
branch
from
September 13, 2019 10:31
1ac022a to
105d63cComparejuliusknorr
commented
Sep 13, 2019
MemberAuthor
Yay, works again: https://drone.nextcloud.com/nextcloud/server/21612/1/3 Rebased and ready for review. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
rullzerforce-pushed
the
bugfix/noid/directory-icon-mount
branch
from
September 15, 2019 17:33
105d63c to
d1724cbCompareThe backport to stable16 failed. Please do this backport manually. |
juliusknorr
commented
Sep 16, 2019
MemberAuthor
/backport to stable17 |
The backport to stable17 failed. Please do this backport manually. |
This was referenced Sep 16, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @jancborchardt the mount type (like groupfolder) should always take precedence of the share folder icon
Steps to reproduce: