Uh oh!
There was an error while loading. Please reload this page.
tidy up adding user to list a little bit - #1701
Merged
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
mention-bot
commented
Oct 11, 2016
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @ringmaster and @icewind1991 to be potential reviewers. |
MorrisJobke
commented
Oct 11, 2016
Member
Tested, works and code looks good 👍 |
MorrisJobke
approved these changes
Oct 11, 2016
MorrisJobke
commented
Oct 11, 2016
Member
Please ignore CI - build finished fine. (I just played around with workers) |
LukasReschke
commented
Oct 13, 2016
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #1679
Just removes unnecessary lines and slightly simplifies the add() method a little bit. No other visible changes.
@MorrisJobke@nickvergessen@rullzer