Uh oh!
There was an error while loading. Please reload this page.
set default CSP on NotFoundResponse - #17078
Merged
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, juliusknorr, nickvergessen and skjnldsvSeptember 9, 2019 20:38
rullzer
commented
Sep 9, 2019
MemberAuthor
/backport to stable17 |
skjnldsv
approved these changes
Sep 10, 2019
ChristophWurst
commented
Sep 10, 2019
Member
Why in NotFoundResponse and not the Response base class? |
rullzer
commented
Sep 10, 2019
MemberAuthor
Because not all responses should have the main CSP set. |
ChristophWurst
approved these changes
Sep 10, 2019
backport to stable17 in #17079 |
nickvergessen
commented
Sep 10, 2019
Member
So actually this could just extend the TemplateResponse? |
rullzer
commented
Sep 10, 2019
MemberAuthor
yes that would also make sense I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found when working on #17077
To test just navigate to an invalid link share.