Uh oh!
There was an error while loading. Please reload this page.
AuthPicker: redirect oauth client to grant page - #17136
Conversation
e6c258c to
4d3dbacCompareantonkarliner
commented
Sep 14, 2019
Great idea! Completely agree. |
4d3dbac to
127a1e6Comparekinolaev
commented
Oct 7, 2019
rullzer
commented
Oct 7, 2019
@kinolaev so it is a leftover from an older time ;) |
Sorry, @rullzer, I didn't understand your position. Do you still like that the users see that message or do you want to simplify oauth login flow now? |
rullzer
commented
Oct 14, 2019
@kinolaev so after some thinking I'm not a huge fan of this. I'd rather make sure that we fix it for all properly. (so also for the normal flow). Let me discuss a bit with @ChristophWurst as well as he moved the login page over to a webpacked thing so maybe we can do something more fancy these days. |
jancborchardt
commented
Dec 10, 2019
Just for reference, design-wise I totally agree with @kinolaev that this needs to be simplified.
Since this is sign in and also connecting to mobile and desktop clients – thus happening a lot, I’d say we should look into this for 19? |
rullzer
commented
Dec 10, 2019
Yeah and witht he improved login page to vue we might now finally be able to tackle it properly. |
b47156a to
46adb7dComparekinolaev
commented
Sep 14, 2020
Hello @rullzer, I resolved merge conflict and moved 'Please log in before granting %1$s access to your %2$s account.' and 'If you are not trying to set up a new device or app, someone is trying to trick you into granting them access to your data. In this case do not proceed and instead contact your system administrator.' messages to LoginForm. Can you review it? |
e268958 to
203f744Comparee293ad9 to
feee428CompareSigned-off-by: Sergej Nikolaev <kinolaev@gmail.com>
Signed-off-by: Sergey Nikolaev <kinolaev@gmail.com>
Signed-off-by: Sergey Nikolaev <kinolaev@gmail.com>
feee428 to
1c12f6dCompareHello @rullzer, |
skjnldsv
commented
Feb 27, 2024
As there is no feedback since a while I will close this ticket. Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
Hello!
This PR skips auth picker page for oauth clients.
For now nextcloud redirects user from
/apps/oauth2/authorizeto/login/flowwhere user sees only login button that redirects user to/login/flow/grantwhere user allows access to account. In other cases/login/flowpage is used to suggest authorization by application password but this is hidden for oauth clients, so this page is actually useless. With this PRClientFlowLogin#showAuthPickerPagereturns redirect to/login/flow/grantinstead of auth picker page andoauthStateremoved from auth picker template because it will always be empty.