Always provide theme color for default personal calendar

[tcitworld]

Before this calendar-color wasn't defined for default calendar

Edited by @georgehrke:
fixes#11256

[nickvergessen]

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

[tcitworld]

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

I feel like it would be more proper to handle this in the theme app. On calendar app side we can fix things by using a border around the calendar color.

[jancborchardt]

Should have a cap at that, so e.g. white doesnt cause issues? Or black on dark theme

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

[georgehrke]

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

Well, but we can't rely on that in CalDAV. iOS calendar, Lightning and other clients have no idea what var(--color-primary-element) is

[jancborchardt]

So we already do have a way to handle that, it’s the var(--color-primary-element) – this ensures it’s capped at a certain grey to be visible.

Well, but we can't rely on that in CalDAV. iOS calendar, Lightning and other clients have no idea what var(--color-primary-element) is

Right – I assume we might have a way in the theming app to hand that over? cc @juliushaertl?

[juliusknorr]

Right – I assume we might have a way in the theming app to hand that over? cc @juliushaertl?

There is no real API for that yet, but the calculation is already done in PHP:

server/apps/theming/lib/Util.php

Line 82 in 30d985b

publicfunctionelementColor($color) {

[tcitworld]

I actually don't remember for sure why we wanted to have VEVENTs-only in the default calendar. Probably for people who were deleting the default task list without noticing they were deleting all of their events at the same time.

[juliusknorr]

Failure looks unrelated but i retriggered drone to be sure since I haven't seen that one failing so far:

/drone/src/tests/acceptance/features/app-files-tags.feature:22