Skip to content

add (hidden) option to configure smb timeout - #17258

Merged
rullzer merged 2 commits into
masterfrom
smb-timeout-config
Sep 27, 2019
Merged

add (hidden) option to configure smb timeout#17258
rullzer merged 2 commits into
masterfrom
smb-timeout-config

Conversation

@icewind1991

@icewind1991icewind1991 commented Sep 25, 2019

Copy link
Copy Markdown
Member

hidden from ui to prevent clutter

occ files_external:config <mount> timeout 30

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991
add (hidden) option to configure smb timeout
194edfc
hidden from ui to prevent clutter
```occ files_external:config <mount> timeout 30```
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Sep 25, 2019
@icewind1991icewind1991 added this to the Nextcloud 18 milestone Sep 25, 2019
@icewind1991

icewind1991 commented Sep 25, 2019

Copy link
Copy Markdown
MemberAuthor

For the future we should look into providing an "advanced settings" mechanism for external storage to put rarely used options like this into

@icewind1991

icewind1991 commented Sep 25, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@icewind1991

icewind1991 commented Sep 25, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

kesselb
kesselb reviewed Sep 25, 2019
View reviewed changes
Comment threadapps/files_external/lib/Lib/Backend/SMB.php Outdated
@icewind1991@kesselb
Update apps/files_external/lib/Lib/Backend/SMB.php
bc16099
Co-Authored-By: Daniel Kesselberg <mail@danielkesselberg.de>
rullzer
rullzer approved these changes Sep 25, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@rullzer
rullzer merged commit 88b6dc5 into masterSep 27, 2019
@rullzer
rullzer deleted the smb-timeout-config branch September 27, 2019 10:29
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 27, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 27, 2019

Copy link
Copy Markdown

backport to stable17 in #17298

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 27, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Sep 27, 2019

Copy link
Copy Markdown

backport to stable16 in #17299

@kesselbkesselb mentioned this pull request Nov 25, 2019
Closed
@XueSheng-GITXueSheng-GIT mentioned this pull request Feb 8, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@rullzer@ChristophWurst@kesselb