Add eslint global nextcloud config

[skjnldsv]

• Waiting for @GretaD's pr in Move users management to multi line #17239

Crazy lots of cleanup! 😑
I found some prettu weird code out there. 🙈

• Leftovers from copy/pasting
• Undeclared variables
• Unchanged vue templates names

Lots of cleanup left to do, but will be in a follow-up

• Put settings components into folders
• Cleanup apps management app that is very hard to understand
• Cleanup the accessibility app too
• Cleanup the updatenotification and simplify it as it's also hard to understand (split into small components)
• Implement proper escape-html
• Cleanup user management
• Fix all the javascript copyright comments that do not start with /** but /*
• ... anything else ?

[rullzer]

so. It all looks sane. I'm just afraid to press approve on such a huge PR...

[go2sh]

Just for curiosity: Is it really necessary to remove all semicolons? I know nearly no guide, which recommends automatic semicolon insertion (ASI). I looked up Google, AirBNB, W3 School, Mozilla. Only StandardJS does. Even the Nextcloud docs says: Complete every statement with a ; ;-)

[skjnldsv]

@go2sh that's a very long debate :p
I think you can find as many posts about why semicolon looks better and are less error-prone than article about why removing them is also less error prone and looks better 🤷‍♀️

In the end, to quote someone: "Discussing about it is opinionated and will induce an endless debate which is not what we want." 😉
https://standardjs.com/#i-disagree-with-rule-x-can-you-change-it

[ChristophWurst]

Files like settings/js/vue-settings-apps-users-management.js have like 25k lines added. Did you compile in dev mode? The bundles should not change their size actually.

[skjnldsv]

Files like settings/js/vue-settings-apps-users-management.js have like 25k lines added. Did you compile in dev mode? The bundles should not change their size actually.

I don't think so! 🤔

EDIT: yes it is :)
Let's wait for #17239 and then I'll rebuild properly!

[go2sh]

@skjnldsv i dont want to start a discussion. I just thought semicolon was the way to go in nextcloud

[skjnldsv]

Bump! I'd like to quickly get this so I don't have to rebase crazy things and also we can catch stuff early for 18 :)

[nickvergessen]

Well I guess we should just rebase and instant merge this
if there are further issues we fix them afterwards, but rebasing +14k -12k is not going to work out.

[skjnldsv]

Well I guess we should just rebase and instant merge this
if there are further issues we fix them afterwards, but rebasing +14k -12k is not going to work out.

let me rebase one last time then

[skjnldsv]

All rebased!
Please do not push anything! Review this asap 🙏

[gary-kim]

While understandable for this one since it would be very wasteful to keep re-basing a change like this, I'd like to ask that merging without reviews not become a pattern. Especially for changes as large as this one.

[nickvergessen]

Surely not becoming a pattern 👍