Skip to content

[stable16] Use handlebars from node_modules (on CI) - #17347

Merged
rullzer merged 1 commit into
stable16from
backport/stable16/fix/hbs-compile-script
Oct 1, 2019
Merged

[stable16] Use handlebars from node_modules (on CI)#17347
rullzer merged 1 commit into
stable16from
backport/stable16/fix/hbs-compile-script

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 1, 2019•
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Member

No description provided.

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 1, 2019
@skjnldsvskjnldsv mentioned this pull request Oct 1, 2019
Merged
@rullzerrullzer added this to the Nextcloud 16.0.6 milestone Oct 1, 2019
@ChristophWurstChristophWurst changed the title Use handlebars from node_modules (on CI)[stable16] Use handlebars from node_modules (on CI)Oct 1, 2019
@rullzer

rullzer commented Oct 1, 2019

Copy link
Copy Markdown
Member

ci says no: https://drone.nextcloud.com/nextcloud/server/22032/4/3

@skjnldsv
skjnldsvforce-pushed the backport/stable16/fix/hbs-compile-script branch from 400e50b to 3880851CompareOctober 1, 2019 07:17
@ChristophWurst

ChristophWurst commented Oct 1, 2019

Copy link
Copy Markdown
Member

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.11.0/linux-x64-72_binding.node

HTTP error 404 Not Found

Apparently they remove their artifacts when new releases are published.

@ChristophWurst

ChristophWurst commented Oct 1, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Found it. We need node-sass@4.12.0 for Node 12. Older release don't work: https://github.com/sass/node-sass/releases/tag/v4.11.0

@skjnldsv

skjnldsv commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

Found it. We need 4.12.0 for Node 12. Older release don't work: https://github.com/sass/node-sass/releases/tag/v4.11.0

so what do we do?

@ChristophWurst

ChristophWurst commented Oct 1, 2019

Copy link
Copy Markdown
Member

so what do we do?

Either downgrade the Docker image to Node <= 11 or update node-sass to 4.12.0

@skjnldsv

skjnldsv commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

Node <= 11

I would prefer this, let's go for node lts?

@ChristophWurst

ChristophWurst commented Oct 1, 2019

Copy link
Copy Markdown
Member

I would prefer this, let's go for node lts?

Fine by me. Or node:11

@skjnldsv
skjnldsvforce-pushed the backport/stable16/fix/hbs-compile-script branch from 3880851 to 86bd86fCompareOctober 1, 2019 09:23
@ChristophWurst@skjnldsv
Use handlebars from node_modules (on CI)
d513d56
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv
skjnldsvforce-pushed the backport/stable16/fix/hbs-compile-script branch from 86bd86f to d513d56CompareOctober 1, 2019 09:23
@skjnldsv

skjnldsv commented Oct 1, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Handlbr tests passed

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 1, 2019
@rullzer
rullzer merged commit c7157ef into stable16Oct 1, 2019
@rullzer
rullzer deleted the backport/stable16/fix/hbs-compile-script branch October 1, 2019 10:07
@rullzerrullzer mentioned this pull request Oct 28, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 16.0.6

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@rullzer@ChristophWurst