Skip to content

[stable17] Use handlebars from node_modules (on CI) - #17348

Merged
rullzer merged 1 commit into
stable17from
backport/stable17fix/hbs-compile-script
Oct 1, 2019
Merged

[stable17] Use handlebars from node_modules (on CI)#17348
rullzer merged 1 commit into
stable17from
backport/stable17fix/hbs-compile-script

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 1, 2019•
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Member

No description provided.

@ChristophWurst@skjnldsv
Use handlebars from node_modules (on CI)
5d98f3f
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsvskjnldsv added bug 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 1, 2019
@skjnldsvskjnldsv mentioned this pull request Oct 1, 2019
Merged
@rullzerrullzer added this to the Nextcloud 17.0.1 milestone Oct 1, 2019
@ChristophWurstChristophWurst changed the title Use handlebars from node_modules (on CI)[stable17] Use handlebars from node_modules (on CI)Oct 1, 2019
@rullzer

rullzer commented Oct 1, 2019

Copy link
Copy Markdown
Member

https://drone.nextcloud.com/nextcloud/server/21998/4/3 ci says no

@skjnldsv
skjnldsvforce-pushed the backport/stable17fix/hbs-compile-script branch from 5d98f3f to fc4b666CompareOctober 1, 2019 07:17
ChristophWurst
ChristophWurst reviewed Oct 1, 2019
View reviewed changes
Comment thread.drone.yml Outdated
@ChristophWurst

ChristophWurst commented Oct 1, 2019

Copy link
Copy Markdown
Member

https://drone.nextcloud.com/nextcloud/server/21998/4/3 ci says no

@ChristophWurst says no. This build is from another PR. The original commit actually passed the Handlebars check :)

@skjnldsv
skjnldsvforce-pushed the backport/stable17fix/hbs-compile-script branch from fc4b666 to 99bbc17CompareOctober 1, 2019 08:03
@skjnldsv

skjnldsv commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

tests passes

@skjnldsv
skjnldsvforce-pushed the backport/stable17fix/hbs-compile-script branch from 99bbc17 to 5d98f3fCompareOctober 1, 2019 08:49
@skjnldsv

skjnldsv commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

Reset back to first backport

@rullzer
rullzer merged commit 95ea467 into stable17Oct 1, 2019
@rullzer
rullzer deleted the backport/stable17fix/hbs-compile-script branch October 1, 2019 09:59
@juliusknorrjuliusknorr mentioned this pull request Oct 4, 2019
Merged
@rullzerrullzer mentioned this pull request Oct 28, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 17.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@rullzer@ChristophWurst