Skip to content

Don't use an undefined index if not needed - #17388

Merged
rullzer merged 1 commit into
masterfrom
fix/undefined_index/loginflowv2
Oct 3, 2019
Merged

Don't use an undefined index if not needed#17388
rullzer merged 1 commit into
masterfrom
fix/undefined_index/loginflowv2

Conversation

@rullzer

@rullzerrullzer commented Oct 3, 2019

Copy link
Copy Markdown
Member

It is not set. And not used. Just some copy paste leftover.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Don't use an undefined index if not needed
1ddd6b4
It is not set. And not used. Just some copy paste leftover.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Oct 3, 2019
@rullzerrullzer added this to the Nextcloud 18 milestone Oct 3, 2019
skjnldsv
skjnldsv approved these changes Oct 3, 2019
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@kesselbkesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2019
@rullzer
rullzer merged commit dcae3e7 into masterOct 3, 2019
@rullzer
rullzer deleted the fix/undefined_index/loginflowv2 branch October 3, 2019 17:12
@rullzer

rullzer commented Oct 3, 2019

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 3, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 3, 2019

Copy link
Copy Markdown

backport to stable17 in #17393

@J0WI

J0WI commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

@rullzer I wonder why this have not been backported to stable16?

@kesselb

kesselb commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

/backport to stable16

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 11, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 11, 2019

Copy link
Copy Markdown

backport to stable16 in #17906

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbkesselb approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer@J0WI@kesselb@nickvergessen@ChristophWurst@skjnldsv