Uh oh!
There was an error while loading. Please reload this page.
Use the external initial state implementation - #17390
Merged
Merged
Conversation
ChristophWurst
commented
Oct 3, 2019
MemberAuthor
🤔 🤔 🤔 |
rullzerforce-pushed
the
refactor/external-initial-state-impl
branch
from
October 4, 2019 09:25
8b71121 to
6d18749Comparerullzer
commented
Oct 4, 2019
Member
Rebased and fixed the eslint warnings... |
rullzer
commented
Oct 4, 2019
Member
still a lot |
rullzer
approved these changes
Oct 4, 2019
skjnldsv
requested changes
Oct 4, 2019
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Let's figure out what the heck is going on before merging :)
ChristophWurstforce-pushed
the
refactor/external-initial-state-impl
branch
2 times, most recently
from
October 9, 2019 10:35
8f8e352 to
ab0845bCompareChristophWurst
commented
Oct 9, 2019
MemberAuthor
@skjnldsv better? |
skjnldsv
commented
Oct 9, 2019
Member
Tests will not pass, right? |
ChristophWurst
commented
Oct 9, 2019
MemberAuthor
They also passed at #17392 (comment), where I think you've used "npm ci" because master build is not reproducible for me right now. |
skjnldsv
commented
Oct 9, 2019
Member
Failed ;) |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
rullzerforce-pushed
the
refactor/external-initial-state-impl
branch
from
October 12, 2019 11:22
ab0845b to
c2e8821Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref nextcloud-libraries/nextcloud-initial-state#22