Uh oh!
There was an error while loading. Please reload this page.
Move to escape-html - #17405
Merged
Merged
Conversation
* If there is a package that does exactly the same then lets us use that * Import it properly in the internals (less deprecation warnings) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliusknorr
approved these changes
Oct 4, 2019
skjnldsv
reviewed
Oct 4, 2019
skjnldsv
left a comment
Member
There was a problem hiding this comment.
I think we should not offer it as a standalone function then.
We deprecated it, let's remove the windows binding and import it where we need it? @ChristophWurst what do you think? Too soon? Shall we wait for another version?
rullzer
commented
Oct 4, 2019
MemberAuthor
the deprecation said it will be removed in 19 ;) |
skjnldsv
commented
Oct 4, 2019
Member
ok then :) |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl