Skip to content

Throw an invalid token exception is token is marked outdated - #17443

Merged
rullzer merged 1 commit into
masterfrom
enh/expired_token_on_invalid_pass
Dec 3, 2019
Merged

Throw an invalid token exception is token is marked outdated#17443
rullzer merged 1 commit into
masterfrom
enh/expired_token_on_invalid_pass

Conversation

@rullzer

@rullzerrullzer commented Oct 7, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This avoids hitting the backend with multiple requests for the same
token. And will help avoid quick LDAP lockouts.

@rullzerrullzer added this to the Nextcloud 18 milestone Oct 7, 2019
@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 15, 2019
@rullzer

rullzer commented Oct 15, 2019

Copy link
Copy Markdown
MemberAuthor

I think this is good to go :)

ChristophWurst
ChristophWurst reviewed Oct 21, 2019
View reviewed changes
Comment threadlib/private/Authentication/Token/PublicKeyTokenProvider.php Outdated
ChristophWurst
ChristophWurst reviewed Oct 29, 2019
View reviewed changes
Comment threadlib/private/Authentication/Exceptions/PasswordExpiredTokenException.php Outdated
ChristophWurst
ChristophWurst reviewed Oct 29, 2019
View reviewed changes
Comment threadlib/private/Authentication/Token/PublicKeyTokenProvider.php
Comment threadlib/private/Authentication/Token/PublicKeyTokenProvider.php Outdated
@rullzer

rullzer commented Nov 13, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Review time

@blizzz this should help a bit with locked out LDAP stuff.
I think this was even one of the origianl use cases when we first talked about it

blizzz
blizzz approved these changes Dec 2, 2019
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@blizzz

blizzz commented Dec 2, 2019

Copy link
Copy Markdown
Member

I think this was even one of the origianl use cases when we first talked about it

Yes, when password changed on the backend. But it used to be working iirc?

@blizzz

This comment has been minimized.

Sign in to view
@rullzer@ChristophWurst
Throw an invalid token exception is token is marked outdated
b371e73
This avoids hitting the backend with multiple requests for the same
token. And will help avoid quick LDAP lockouts.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@ChristophWurst
ChristophWurstforce-pushed the enh/expired_token_on_invalid_pass branch from 35facfc to b371e73CompareDecember 2, 2019 17:57
@rullzer
rullzer merged commit 9fce87b into masterDec 3, 2019
@rullzer
rullzer deleted the enh/expired_token_on_invalid_pass branch December 3, 2019 07:59
@ChristophWurst

ChristophWurst commented Dec 3, 2019

Copy link
Copy Markdown
Member

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Dec 3, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Dec 3, 2019

Copy link
Copy Markdown

backport to stable17 in #18198

@joshtrichardsjoshtrichards mentioned this pull request Mar 14, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@icewind1991icewind1991Awaiting requested review from icewind1991
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@blizzz@ChristophWurst