Uh oh!
There was an error while loading. Please reload this page.
hide strange Everyone and Disabled group numbers with LDAP - #17450
Merged
Conversation
juliusknorr
approved these changes
Oct 7, 2019
juliusknorr
commented
Oct 7, 2019
Member
Bundles need to be updated as well |
blizzz
commented
Oct 7, 2019
MemberAuthor
/compile /apps/settings |
skjnldsv
reviewed
Oct 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
blizzzforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 8, 2019 08:36
c566902 to
68ea78eCompareskjnldsv
reviewed
Oct 8, 2019
| groups.unshift(disabledGroup) | ||
| if (disabledGroup.utils.counter === -1) { | ||
| // hides the counter instead of showing -1 | ||
| delete disabledGroup.utils.counter |
Member
There was a problem hiding this comment.
Ah wait, I'm an idiot.
Did not saw the line above. If you do this, then the next call will remove the disable entry in the menu 🙈
We should definitely find another way 😬
MemberAuthor
There was a problem hiding this comment.
Nope, at least it was not removed for me locally. Did you try, or do you assume? :D
MemberAuthor
There was a problem hiding this comment.
As said, it works for me both ways.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
blizzz
commented
Oct 11, 2019
MemberAuthor
it's a bit cumbersome for resources only being built |
blizzzforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 14, 2019 10:08
cacbdce to
67c9590Compareblizzzforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 15, 2019 15:17
67c9590 to
da90156Compareblizzz
commented
Oct 15, 2019
MemberAuthor
rebased again… |
skjnldsv
approved these changes
Oct 15, 2019
blizzz
commented
Oct 15, 2019
MemberAuthor
Ah, I have an addition: group numbers are also increased or decreased when a user is added or removed from a group. Commit comming soon. |
blizzzforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 15, 2019 16:21
da90156 to
a7f4f71Compareblizzz
commented
Oct 16, 2019
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 16, 2019 08:25
a7f4f71 to
e68492dCompareblizzz
commented
Oct 16, 2019
MemberAuthor
/backport to stable17 |
blizzz
commented
Oct 16, 2019
MemberAuthor
/backport to stable16 |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/17368/odd-group-numbers
branch
from
October 21, 2019 08:09
e68492d to
72a8703Compareblizzz
commented
Oct 21, 2019
MemberAuthor
/compile / |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
The backport to stable17 failed. Please do this backport manually. |
The backport to stable16 failed. Please do this backport manually. |
blizzz added a commit
that referenced
this pull request
Oct 21, 2019
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz added a commit
that referenced
this pull request
Oct 21, 2019
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#17368
Before:
Now: