Uh oh!
There was an error while loading. Please reload this page.
[stable17] Fix axios csrf token update event - #17453
Merged
Merged
Conversation
1 task
skjnldsv
approved these changes
Oct 8, 2019
rullzer
approved these changes
Oct 9, 2019
rullzer
commented
Oct 9, 2019
Member
mmm webpack is not happy |
rullzer
commented
Oct 9, 2019
Member
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
fix/axios-csrf-token-update-event-stable17
branch
from
October 9, 2019 08:19
c39db70 to
5586ab2Compareskjnldsv
commented
Oct 9, 2019
Member
Same issue! you need npm ci. @ChristophWurst shall we use npm i in the tests instead? |
rullzerforce-pushed
the
fix/axios-csrf-token-update-event-stable17
branch
2 times, most recently
from
October 14, 2019 19:17
d352659 to
58bfc22Comparerullzer
commented
Oct 14, 2019
Member
/compile amend / |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
fix/axios-csrf-token-update-event-stable17
branch
from
October 14, 2019 19:32
58bfc22 to
f49f1afCompare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial backport of #17404 that allows apps that use the new
@nextcloud/axiosto keep the request token in sync.I'll try to update Axios for stable17 as well. But it's a bigger/riskier change, thus left it out of this manual backport.
To test this PR you can run _nc_event_bus.emit('csrf-token-update', {token: 123}) and observe that OC.requestToken updates.