Skip to content

fix filename overlapping on mobile - #17469

Merged
skjnldsv merged 2 commits into
masterfrom
bug/17364/fix_filename_overlapping_mobile
Oct 25, 2019
Merged

fix filename overlapping on mobile#17469
skjnldsv merged 2 commits into
masterfrom
bug/17364/fix_filename_overlapping_mobile

Conversation

@GretaD

@GretaDGretaD commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

ref #17364

@GretaD
fix filename overlapping on mobile ref#17364
e4ab146
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD
add comment
c0cf9d5
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD
GretaD requested review from jancborchardt and skjnldsv and removed request for jancborchardtOctober 8, 2019 15:58
@rullzerrullzer added 3. to review Waiting for reviews enhancement labels Oct 8, 2019
@rullzerrullzer added this to the Nextcloud 18 milestone Oct 8, 2019
@jancborchardt

jancborchardt commented Oct 12, 2019

Copy link
Copy Markdown
Member

@Bables55@Octopus2@AndyFx12@DmDS@elpraga@justasomeone since you reported this in issue #17364, could you try testing and reviewing this fix? That helps a lot, thanks! :)

@Octopus2

Octopus2 commented Oct 12, 2019•
edited
Loading

Copy link
Copy Markdown

Screenshot_20191012-123741_Chrome

I changed the scss-file on my 17.0 installation. I used "maintenance:repair"in the console and cleared the browsercache to see these changes. It looks much better now. But there is no 3-dots-menu in root....

@Octopus2

Octopus2 commented Oct 12, 2019

Copy link
Copy Markdown

Screenshot_20191012-123555_Chrome

Interesting: Subfolders have a 3-dot-menu....

@Octopus2

Octopus2 commented Oct 12, 2019

Copy link
Copy Markdown

I played around on root: when i change the view from details to thumbnail and then back i get the three-dots-menu.... But its gone after reloading the page....

@elpraga

elpraga commented Oct 12, 2019

Copy link
Copy Markdown

I've just applied the patch. And everything seems to be working as expected. I can see even the three dot menu in the root folder.

@AndyFx12

AndyFx12 commented Oct 13, 2019

Copy link
Copy Markdown

Sorry - but this fix seems not to work (or I did something wrong ...).

NC17.0 with fixes
Screenshot_20191013-203429

NC16.05:
Screenshot_20191013-203630

Andy

juliusknorr
juliusknorr approved these changes Oct 22, 2019
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr

juliusknorr commented Oct 22, 2019

Copy link
Copy Markdown
Member

@AndyFx12 We cache css files pretty heavily on production systems. Try running occ maintenance:repair after the patch is applied.

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2019
@juliusknorr

juliusknorr commented Oct 22, 2019

Copy link
Copy Markdown
Member

/backport to stable17

@juliusknorrjuliusknorr mentioned this pull request Oct 22, 2019
Closed
@jancborchardt

jancborchardt commented Oct 25, 2019

Copy link
Copy Markdown
Member

What about the Drone failure here? :)

@AndyFx12

AndyFx12 commented Oct 25, 2019

Copy link
Copy Markdown

After occ maintenance:repair AND clear browser-cache it works fine:
Screenshot_20191025-143510

@skjnldsv
skjnldsv merged commit 6d9bcb7 into masterOct 25, 2019
@skjnldsv
skjnldsv deleted the bug/17364/fix_filename_overlapping_mobile branch October 25, 2019 12:59
@skjnldsv

skjnldsv commented Oct 25, 2019

Copy link
Copy Markdown
Member

What about the Drone failure here? :)

timeouts :)

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 25, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 25, 2019

Copy link
Copy Markdown

backport to stable17 in #17676

@jancborchardt

jancborchardt commented Oct 25, 2019

Copy link
Copy Markdown
Member

Hmm, it actually looks a bit strange, the share icon and the avatars are not horizontally aligned, but right-aligned?

@juliusknorr

juliusknorr commented Oct 26, 2019

Copy link
Copy Markdown
Member

@jancborchardt Please open a new issue. It is not really related as it was like that before. 😉

@Octopus2Octopus2 mentioned this pull request Oct 28, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@GretaD@jancborchardt@Octopus2@elpraga@AndyFx12@juliusknorr@skjnldsv@rullzer