Uh oh!
There was an error while loading. Please reload this page.
Include the share in the Files_Sharing::loadAdditionalScripts event - #17575
Merged
rullzer merged 1 commit intoOct 19, 2019
Merged
Conversation
danxuliu
requested review from
ChristophWurst, juliusknorr, rullzer and skjnldsvOctober 17, 2019 08:35
danxuliu
commented
Oct 17, 2019
MemberAuthor
/backport to stable17 |
danxuliu
commented
Oct 17, 2019
MemberAuthor
Wait, do not review yet 🤦♂️ |
danxuliu
commented
Oct 17, 2019
MemberAuthor
Done. The tests passed because only the first parameter was being checked; I have extended them to also test the new parameter. I have also changed the parameter from |
rullzer
approved these changes
Oct 17, 2019
rullzer
left a comment
Member
There was a problem hiding this comment.
Those should be converted to the new events 😉
But sure.
juliusknorr
approved these changes
Oct 17, 2019
This provides a better context for apps using the event, for example to load one script or another depending on whether the share is a file or a folder. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliuforce-pushed
the
include-the-share-in-the-files_sharing-loadadditionalscripts-event
branch
from
October 17, 2019 16:24
f6c38e5 to
5c7c308Comparedanxuliu
commented
Oct 17, 2019
MemberAuthor
Squashed. |
rullzer
deleted the
include-the-share-in-the-files_sharing-loadadditionalscripts-event
branch
October 19, 2019 09:13
backport to stable17 in #17597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a better context for apps using the event, for example to load one script or another depending on whether the share is a file or a folder.
This should be backported to Nextcloud 17, as it is needed by Talk to fix some issues in the public share page for folder shares.