Skip to content

Make sure the UID is correctly cased - #1766

Merged
MorrisJobke merged 1 commit into
masterfrom
force-uid-casing-on-transfer-ownership
Oct 17, 2016
Merged

Make sure the UID is correctly cased#1766
MorrisJobke merged 1 commit into
masterfrom
force-uid-casing-on-transfer-ownership

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Try to transfer files from user test1 to test2 with the command occ files:transfer-ownership Test1 Test2

@MorrisJobke@LukasReschke

@mention-bot

Copy link
Copy Markdown

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @LukasReschke and @carlaschroder to be potential reviewers.

@LukasReschke

Copy link
Copy Markdown
Member

👍

@MorrisJobke

Copy link
Copy Markdown
Member

Doesn't work for me - the transfer then doesn't work at all after checking out this branch. No folder transferred from test1 on 2016-10-17T11:22:25+00:00 is created with this branch even if the correct naming is used. 👎

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the force-uid-casing-on-transfer-ownership branch from 41d1530 to 77a5491CompareOctober 17, 2016 11:42
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Fixed

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2016
@codecov-io

Copy link
Copy Markdown

Current coverage is 57.26% (diff: 0.00%)

Merging #1766 into master will decrease coverage by <.01%

@@ master #1766 diff @@
==========================================
Files 1075 1075 Lines 61274 61278 +4 Methods 6864 6864 Messages 0 0 Branches 0 0 ==========================================
Hits 35093 35093 - Misses 26181 26185 +4 
Partials 0 0 

Sunburst

Diff CoverageFile Path
0%apps/files/lib/Command/TransferOwnership.php

Powered by Codecov. Last update 96f8f20...77a5491

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@mention-bot@LukasReschke@MorrisJobke@codecov-io