Uh oh!
There was an error while loading. Please reload this page.
Do not show 'Get your own free account' on services under subscription - #17674
Merged
Conversation
rullzer
requested review from
juliusknorr, nickvergessen, skjnldsv and tobiasKaminskyOctober 25, 2019 11:56
Uh oh!
There was an error while loading. Please reload this page.
kesselb
reviewed
Oct 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
enh/do_not_show_footer_sub
branch
from
October 25, 2019 14:46
ecc36c8 to
931c68cComparekesselb
approved these changes
Oct 29, 2019
kesselb
left a comment
Contributor
There was a problem hiding this comment.
There is no way to show the signup link if you have a subscription. Guess that's acceptable.
rullzer
commented
Oct 29, 2019
MemberAuthor
yeah fine by me :) If somebody complains we'll see about it then. |
rullzer
commented
Oct 29, 2019
MemberAuthor
/backport to stable17 |
tobiasKaminsky
approved these changes
Oct 30, 2019
backport to stable17 in #17748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl