Skip to content

Show first day of the week in correct language - #17691

Merged
rullzer merged 1 commit into
masterfrom
enh/17673/fix-first-day-week
Oct 26, 2019
Merged

Show first day of the week in correct language#17691
rullzer merged 1 commit into
masterfrom
enh/17673/fix-first-day-week

Conversation

@kesselb

@kesselbkesselb commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

Follow-Up for #17673. Should be backportable without .eslintrc.

Master
image

This PR
image

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added enhancement 3. to review Waiting for reviews labels Oct 26, 2019
@kesselbkesselb added this to the Nextcloud 18 milestone Oct 26, 2019
Comment thread.eslintrc.js
escapeHTML: true,
oc_userconfig: true
oc_userconfig: true,
dayNames: true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start exposing this via a proper API. But different time ;)

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 26, 2019
@rullzer
rullzer merged commit 790efdf into masterOct 26, 2019
@rullzer
rullzer deleted the enh/17673/fix-first-day-week branch October 26, 2019 18:32
@draecke

Copy link
Copy Markdown

It doesn't work right. I set Language to "Deutsch" and Locale "Englisch(Irland)" and the calendar shows Sunday as the first day of the week.
Language

@georgehrke

Copy link
Copy Markdown
Member

It doesn't work right. I set Language to "Deutsch" and Locale "Englisch(Irland)" and the calendar shows Sunday as the first day of the week.

That is an issue in the calendar, see nextcloud/calendar#1844

@draecke

Copy link
Copy Markdown

Ok thank you for your express reply.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@draecke@georgehrke@rullzer@skjnldsv