Uh oh!
There was an error while loading. Please reload this page.
Remove objectstore credentials - #17696
Merged
Merged
Conversation
S3: key and secret Swift v3: user.name and user.password Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Also remove the username for Swift v2 and add todo for unclear keys. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
rullzer
approved these changes
Oct 31, 2019
rullzer
reviewed
Oct 31, 2019
| 'objectstore' => [ | ||
| 'arguments' => [ | ||
| 'password' => true, | ||
| // @Todo: Is this still valid? |
ContributorAuthor
There was a problem hiding this comment.
Is this a change request? 🤔 Todo refers to options => ['credentials => [...]]. password is still there just moved it below to Swift v2. I could not find any usage for the options syntax.
Member
There was a problem hiding this comment.
yeah it is ancient swift code but could still be in use
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Uh oh!
There was an error while loading. Please reload this page.
nickvergessen
approved these changes
Nov 6, 2019
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Fine in general, but I would keep the password thingy just to be sure
nickvergessen
approved these changes
Nov 6, 2019
kesselb
commented
Nov 22, 2019
ContributorAuthor
/backport to stable17 |
backport to stable17 in #18075 |
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close#17659
S3: key and secret
Swift v2: also remove the username
Swift v3: user.name and user.password