Uh oh!
There was an error while loading. Please reload this page.
Make sure limit is never negative - #17712
Merged
Merged
Conversation
There were some cases where a negative limit could be passed in. Which would happily make the query explode. This is just a quick hack to make sure it never is negative. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, danxuliu, juliusknorr, kesselb and nickvergessenOctober 28, 2019 12:09
nickvergessen
approved these changes
Oct 28, 2019
ChristophWurst
approved these changes
Oct 28, 2019
rullzer
commented
Oct 28, 2019
MemberAuthor
/backport to stable17 |
rullzer
commented
Oct 28, 2019
MemberAuthor
/backport to stable16 |
The backport to stable16 failed. Please do this backport manually. |
backport to stable17 in #17716 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some cases where a negative limit could be passed in. Which
would happily make the query explode.
This is just a quick hack to make sure it never is negative.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl