Skip to content

Fix reshare with circle - #17735

Merged
ChristophWurst merged 1 commit into
nextcloud:masterfrom
tcoupin:fix-reshare-circle
Nov 4, 2019
Merged

Fix reshare with circle#17735
ChristophWurst merged 1 commit into
nextcloud:masterfrom
tcoupin:fix-reshare-circle

Conversation

@tcoupin

@tcoupintcoupin commented Oct 29, 2019•
edited
Loading

Copy link
Copy Markdown
Member

See nextcloud/circles#346

Reshare with circle does not work. This PR fix this.

@tcoupin
Fix reshare with circle
7cca169
Signed-off-by: Thibault Coupin <thibault.coupin@gmail.com>
@tcoupin

tcoupin commented Oct 31, 2019

Copy link
Copy Markdown
MemberAuthor

This PR is very important for my work installation since we use "circle quota" (technical account who shares root with circles of local admin, with reshare permission). Today, local admin can not share a folder shared by the technical account. It's very blocking...

@kesselbkesselb added this to the Nextcloud 18 milestone Oct 31, 2019
ArtificialOwl
ArtificialOwl approved these changes Oct 31, 2019
View reviewed changes

@ArtificialOwlArtificialOwl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

gary-kim
gary-kim approved these changes Nov 4, 2019
View reviewed changes

@gary-kimgary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my! The CI tests actually all passed for once! This should not be something unusual...

@ChristophWurst
ChristophWurst merged commit a767a2f into nextcloud:masterNov 4, 2019
@welcome

welcomeBot commented Nov 4, 2019

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@tcoupin
tcoupin deleted the fix-reshare-circle branch November 5, 2019 08:34
@tcoupin

tcoupin commented Nov 12, 2019

Copy link
Copy Markdown
MemberAuthor

Will this PR be released in version 17.x ?

@ChristophWurst

ChristophWurst commented Nov 12, 2019

Copy link
Copy Markdown
Member

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 12, 2019
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 12, 2019

Copy link
Copy Markdown

backport to stable17 in #17916

@ArtificialOwlArtificialOwl mentioned this pull request Dec 8, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwlArtificialOwlArtificialOwl approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@gary-kimgary-kimgary-kim approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tcoupin@ChristophWurst@ArtificialOwl@gary-kim@kesselb