Skip to content

More workflow frontend polishing - #17997

Merged
rullzer merged 7 commits into
masterfrom
enh/workflow-frontend
Nov 27, 2019
Merged

More workflow frontend polishing#17997
rullzer merged 7 commits into
masterfrom
enh/workflow-frontend

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 19, 2019

Copy link
Copy Markdown
Member

Another round of polishing for workflows as discussed at the contributor week:

  • Rename to Flow
  • Available actions as top header
  • Configured flows as rule header
  • green border around active, cursor should not be a pointer in active
  • Move tags to basic settings, when working on the ui, move it to a dedicated section
  • Add "More actions" button to the end, link to the app store
  • add link to documentation for app developers

image

ToDo for later polishing

  • The icons in the action boxes can be a bit closer to the text below. Should have same distance from the text as the button below
  • when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)
  • on wide windows, show more than 3 operations per row

@juliusknorrjuliusknorr added this to the Nextcloud 18 milestone Nov 19, 2019
@juliusknorrjuliusknorr changed the title Enh/workflow frontendMore workflow frontend polishingNov 19, 2019
@jancborchardt

jancborchardt commented Nov 19, 2019

Copy link
Copy Markdown
Member

Great stuff! Only tiny things:

  • The icons in the action boxes can be a bit closer to the text below. Should have same distance from the text as the button below
  • "check out" is 2 words, and the sentence needs a dot at the end. Also, is "development documentation" linked → if not it should be.
  • "Create a new rule" on the button should better be "Add new flow". We never use the word "rule" anywhere, and the 2 words "action" and "flow" are already enough terminology.
  • "Configured flows" better "Your flows"?
  • "Your flows" heading needs more whitespace to top. Usually we do this via a class="section" container, but since we use that for the flow list themselves we need to add it manually?

👍

@jancborchardt

Copy link
Copy Markdown
Member

I’m also thinking to totally drop the "actions" term in favor of only saying "flow" everywhere.

  • Headings: "Available flows" and "Your flows".
  • Button: "Add new flow"
  • Text; "For details on how to write your own flow, …"
  • Box: "More flows" "Browse the app store"

This makes it much simpler and understandable. We don’t need to differentiate between "unfinished flows" and "flows". What do you think @karlitschek@jospoortvliet?

@blizzz

Copy link
Copy Markdown
Member

Also needs nextcloud/appstore#628

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for further polishing:

  • when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)
  • on wide windows, show more than 3 operations per row

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this. And fix the rest in follow ups

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Fixed wording issues and rebase. Leaving the rest for polishing later.

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 26, 2019
@rullzer

Copy link
Copy Markdown
Member

tests do 💥

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Should run fine now, let's see

@rullzer
rullzer merged commit a2046db into masterNov 27, 2019
@rullzer
rullzer deleted the enh/workflow-frontend branch November 27, 2019 07:36
@rullzer

Copy link
Copy Markdown
Member

Done!

@juliushaertl can you make issues out of the open todos?

@juliusknorrjuliusknorr mentioned this pull request Dec 2, 2019
@juliusknorrjuliusknorr mentioned this pull request Dec 23, 2019
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@jancborchardt@blizzz@rullzer