Uh oh!
There was an error while loading. Please reload this page.
Convert more columns to bigint - #18004
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, georgehrke, juliusknorr, kesselb and nickvergessenNovember 19, 2019 13:01
georgehrke
approved these changes
Nov 19, 2019
georgehrke
left a comment
Member
There was a problem hiding this comment.
Code looks good, tested and works 👍
We might want to consider renaming occ db:convert-filecache-bigint in the future, since it's no longer only about the file-cache
georgehrke
commented
Nov 19, 2019
Member
@rullzer Backport? |
rullzer
commented
Nov 19, 2019
MemberAuthor
/backport to stable17 |
rullzer
commented
Nov 19, 2019
MemberAuthor
/backport to stable16 |
ChristophWurst
approved these changes
Nov 19, 2019
nickvergessen
approved these changes
Nov 19, 2019
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
enh/more_bigint_columns
branch
from
November 20, 2019 18:31
fddb147 to
decdb6bComparebackport to stable17 in #18040 |
backport to stable16 in #18041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl