Skip to content

Extract transfer ownership logic into a reusable service - #18025

Merged
rullzer merged 1 commit into
masterfrom
refactor/extract-ownership-transfer-service
Nov 26, 2019
Merged

Extract transfer ownership logic into a reusable service#18025
rullzer merged 1 commit into
masterfrom
refactor/extract-ownership-transfer-service

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Nov 20, 2019

Copy link
Copy Markdown
Member

This will make

Tested with a simple guest account.

@ChristophWurstChristophWurst added this to the Nextcloud 18 milestone Nov 20, 2019
@ChristophWurstChristophWurst self-assigned this Nov 20, 2019
nickvergessen
nickvergessen reviewed Nov 20, 2019
View reviewed changes
Comment threadapps/files/lib/Service/OwnershipTransferService.php
nickvergessen
nickvergessen reviewed Nov 20, 2019
View reviewed changes
Comment threadapps/files/lib/Service/OwnershipTransferService.php Outdated
nickvergessen
nickvergessen reviewed Nov 20, 2019
View reviewed changes
Comment threadapps/files/lib/Service/OwnershipTransferService.php Outdated
nickvergessen
nickvergessen approved these changes Nov 20, 2019
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rullzer
rullzer approved these changes Nov 21, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2019
@ChristophWurstChristophWurst mentioned this pull request Nov 21, 2019
Merged
2 tasks
@rullzerrullzer mentioned this pull request Nov 21, 2019
Merged
15 tasks
@rullzer

rullzer commented Nov 21, 2019

Copy link
Copy Markdown
Member

rebase and autosquash first ;)

@ChristophWurst
ChristophWurstforce-pushed the refactor/extract-ownership-transfer-service branch from e890a03 to 36ee58aCompareNovember 21, 2019 10:00
@ChristophWurstChristophWurst mentioned this pull request Nov 22, 2019
Closed
@rullzer
rullzerforce-pushed the refactor/extract-ownership-transfer-service branch from 36ee58a to 44aa4f1CompareNovember 25, 2019 07:42
@rullzer

rullzer commented Nov 26, 2019

Copy link
Copy Markdown
Member

And another rebase. But then we can get it in I guess

@ChristophWurst@rullzer
Extract transfer ownership logic into a reusable service
07c5f37
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer
rullzerforce-pushed the refactor/extract-ownership-transfer-service branch from 44aa4f1 to 07c5f37CompareNovember 26, 2019 07:50
@rullzer
rullzer merged commit dfe85ae into masterNov 26, 2019
@rullzer
rullzer deleted the refactor/extract-ownership-transfer-service branch November 26, 2019 08:32
@ChristophWurstChristophWurst mentioned this pull request Dec 13, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@rullzer@nickvergessen