Uh oh!
There was an error while loading. Please reload this page.
add fullscreen icon - #1803
Conversation
mention-bot
commented
Oct 19, 2016
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @LukasReschke and @nickvergessen to be potential reviewers. |
LukasReschke
commented
Oct 19, 2016
LGTM! 🚀 |
skjnldsv
commented
Oct 19, 2016
To the moon! |
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="16" width="16" version="1.1"> | |||
There was a problem hiding this comment.
missing viewbox, so firefox does not rage quit?
There was a problem hiding this comment.
yes, please viewBox="0 0 16 16"
karlitschek
commented
Oct 19, 2016
great idea 👍 |
rullzer
commented
Oct 19, 2016
Why backport? This is introducing something new. |
MariusBluem
commented
Oct 19, 2016
Because Spreed, Gallery and maybe other apps will depend on it 😁 @rullzer |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
6973079 to
c52ccbdComparejancborchardt
commented
Oct 19, 2016
Yup, what @MariusBluem said. If we use it in these apps, they need to stay backwards-compatible. |
rullzer
commented
Oct 19, 2016
Well they should not depend on stuff that wasn't there. Ship their own icons. Or say they only support NC11. But I'm not having the whole backport discussion again. |
codecov-io
commented
Oct 19, 2016
Current coverage is 57.35% (diff: 100%)@@ master #1803 diff @@
==========================================
Files 1075 1075 Lines 61313 61315 +2 Methods 6865 6865 Messages 0 0 Branches 0 0 ==========================================
+ Hits 35163 35166 +3 + Misses 26150 26149 -1
Partials 0 0
|
MorrisJobke
commented
Oct 19, 2016
👍 |
Useful for Gallery, Spreed and other things. We should also backport it to the stable branches. cc @karlitschek
Please review @nextcloud/designers