Uh oh!
There was an error while loading. Please reload this page.
Drop php 7.1 support - #18062
Conversation
rullzer
commented
Nov 22, 2019
@danxuliu I guess all the tests are converted now away from 7.1 right? |
Just for the record, this will require adjustments in all apps. But there is a script for that 😎 Hopefully I can do that tonight or sometime before monday when everyone tries to push to any app and it just breaks. Is 7.4 already stable enough to be added before? If so, it would be nice to:
Otherwise all PRs I have to create will be red CI |
rullzer
commented
Nov 22, 2019
7.4 PR is on its way. But they are at rc6 so yeah good enough to use in app (but server doesn't run on it yet). We could of course just wait merging this till your script ran |
rullzer
commented
Nov 22, 2019
Ok lets wait for #18064 to be done then |
danxuliu
commented
Nov 22, 2019
In theory, yes. Some integration tests failed, although it seems that they failed already in #18063. |
Uh oh!
There was an error while loading. Please reload this page.
18 will be relased when php7.1 is EOL already. So lets kill it! Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliusknorr
commented
Nov 28, 2019
Pushed a new tag for integration-php7.3 that needs to be bumped once available on docker hub. |
rullzer
commented
Nov 28, 2019
Sure but we can also do that separatly. The changes were not part of this PR so dropping 7.1 here is not related to that. |
18 will be relased when php7.1 is EOL already. So lets kill it!
Blocked by:
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl