Skip to content

Properly handle resources in ReminderService - #18115

Merged
rullzer merged 1 commit into
masterfrom
bugfix/17951/reminderservice_resource_error
Dec 27, 2019
Merged

Properly handle resources in ReminderService#18115
rullzer merged 1 commit into
masterfrom
bugfix/17951/reminderservice_resource_error

Conversation

@georgehrke

@georgehrkegeorgehrke commented Nov 26, 2019

Copy link
Copy Markdown
Member

fixes#17951

@georgehrke
Properly handle resources in ReminderService
05e47af
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrkegeorgehrke added the 3. to review Waiting for reviews label Nov 26, 2019
@georgehrkegeorgehrke mentioned this pull request Nov 26, 2019
Closed
@georgehrke

georgehrke commented Nov 26, 2019

Copy link
Copy Markdown
MemberAuthor

waiting for responses in #17951, will request reviews after that

@georgehrke

georgehrke commented Nov 29, 2019

Copy link
Copy Markdown
MemberAuthor

Responses in #17951 are positive that this fixes the issue

@kesselb

kesselb commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

Code looks good. Have you found a way to reproduce it?

server/apps/dav/lib/CalDAV/Reminder/Backend.php

Line 207 in c7d5b8f

privatefunctionfixRowTyping(array$row): array {
probably it's possible to do stream_get_contents here. No duplicate code than ;)

@tcitworld

tcitworld commented Nov 29, 2019

Copy link
Copy Markdown
Member

I reproduce it too on my own production server.

@gary-kimgary-kim added this to the Nextcloud 18 milestone Dec 24, 2019
gary-kim
gary-kim approved these changes Dec 27, 2019
View reviewed changes

@gary-kimgary-kim left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gary-kimgary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 27, 2019
This was referenced Dec 27, 2019
Merged
Merged
@rullzer
rullzer merged commit b7f93cc into masterDec 27, 2019
@rullzer
rullzer deleted the bugfix/17951/reminderservice_resource_error branch December 27, 2019 13:42
@enoch85

enoch85 commented Dec 28, 2019

Copy link
Copy Markdown
Member

Thanks! I don't see any backport request, would that be possible?

@georgehrke

georgehrke commented Jan 14, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 14, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 14, 2020

Copy link
Copy Markdown

backport to stable17 in #18880

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb approved these changes
@gary-kimgary-kimgary-kim approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

ReminderService::parseCalendarData() must be of the type string

6 participants

@georgehrke@kesselb@tcitworld@enoch85@gary-kim@rullzer