Uh oh!
There was an error while loading. Please reload this page.
allow user flows when the acting user is legitimate, but not its owner - #18134
Merged
Conversation
blizzzforce-pushed
the
enh/noid/flow-extend-scope
branch
from
November 27, 2019 15:05
ed6936e to
a79ab62Compareblizzz
marked this pull request as ready for review
November 27, 2019 15:06
blizzz
requested review from
ArtificialOwl, ChristophWurst, nickvergessen and rullzerNovember 27, 2019 15:07
5 tasks
Uh oh!
There was an error while loading. Please reload this page.
blizzzforce-pushed
the
enh/noid/flow-extend-scope
branch
from
November 28, 2019 09:53
3c81ed3 to
22f5fc8Compareblizzz
commented
Nov 28, 2019
MemberAuthor
Tests also need #18143 it seems |
rullzer
commented
Nov 28, 2019
Member
in |
juliusknorr
commented
Nov 28, 2019
Member
@blizzz I pushed another commit to set the file info in the rule matcher. That was missing when I tested it with the talk operation. Please give it a quick sanity check. Otherwise looks good to me and works as advertised. |
for instance, when a sharee changes a file, the owner can act upon Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
the File entity starts with a display text (used by talk) Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
blizzzforce-pushed
the
enh/noid/flow-extend-scope
branch
from
November 28, 2019 12:51
901510e to
260f0faCompareSigned-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
commented
Nov 28, 2019
MemberAuthor
remaining failing tests are irrelevant to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for instance, when a sharee changes a file, the owner can act upon
To Dos: