Uh oh!
There was an error while loading. Please reload this page.
Trim the login name - #18135
Merged
Merged
Conversation
ChristophWurst
requested review from
gary-kim, georgehrke, juliusknorr, kesselb and rullzerNovember 27, 2019 13:59
juliusknorr
approved these changes
Nov 27, 2019
ChristophWurst
commented
Nov 27, 2019
MemberAuthor
/backport to stable17 |
ChristophWurst
commented
Nov 27, 2019
MemberAuthor
/backport to stable16 |
gary-kim
approved these changes
Nov 27, 2019
Otherwise we keep on using it with leading or trailing whitespaces for app tokens and other logic. The reason this doesn't throw an error immediately with local users is that (My)SQL compares strings regardless of their padding by default. So we look up 'uid ' and get the row for the user 'uid'. Other back-ends will lead to a hard error, though, and the user is unable to log out as all request fail. Ref https://stackoverflow.com/a/10495807/2239067 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
rullzerforce-pushed
the
fix/trim-login-name
branch
from
November 28, 2019 19:52
1db73ba to
81e35d0Comparegeorgehrke
commented
Nov 29, 2019
Member
@rullzer merge? |
backport to stable17 in #18156 |
The backport to stable16 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we keep on using it with leading or trailing whitespaces for
app tokens and other logic. The reason this doesn't throw an error
immediately with local users is that (My)SQL compares strings regardless
of their padding by default. So we look up 'uid ' and get the row for
the user 'uid'.
Other back-ends will lead to a hard error, though, and the user is
unable to log out as all request fail.
Ref https://stackoverflow.com/a/10495807/2239067