Skip to content

Fix provisioning_api getUsers types - #18142

Merged
rullzer merged 1 commit into
masterfrom
fix/provisioning_api/users-typing
Nov 29, 2019
Merged

Fix provisioning_api getUsers types#18142
rullzer merged 1 commit into
masterfrom
fix/provisioning_api/users-typing

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 28, 2019

Copy link
Copy Markdown
Member

Fix#17903, Fix#18137

Please review @Ases@finalls@markuman@markushagge@nursoda@j-ed

Otherwise it is passed as string and ignored by the Users Backend

privatefunctionfixLimit($limit) {
if (is_int($limit) && $limit >= 0) {
return$limit;
}
returnnull;
}

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2019
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Lots of failures, are those related?

@kesselb

kesselb commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

Lots of failures, are those related?

No. #18143

@kesselb

Copy link
Copy Markdown
Contributor

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@kesselb

Copy link
Copy Markdown
Contributor

No 🤣 Sorry for the noise. I edited your post, changed the issue number (leading 1 was missing) and added another issue: Fix #17903, #18137 But this syntax is invalid and @gary-kim tried to fix it.

@nursoda

Copy link
Copy Markdown

Should I worry about "continuous-integration/drone/pr — Build is failing" or try to modify my production system with the PR?

@kesselb

Copy link
Copy Markdown
Contributor

Should I worry about "continuous-integration/drone/pr — Build is failing"

No. But if you patch your instance always make a backup.

@Ases

Ases commented Nov 28, 2019

Copy link
Copy Markdown

Please review @Ases@finalls@markuman@markushagge@nursoda@j-ed

It works!!! Thank you @skjnldsv

@AsesAses left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the problem. 👍

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer
rullzerforce-pushed the fix/provisioning_api/users-typing branch from fa16a6e to f675e61CompareNovember 28, 2019 19:28
@rullzer
rullzer merged commit b552da5 into masterNov 29, 2019
@rullzer
rullzer deleted the fix/provisioning_api/users-typing branch November 29, 2019 08:04
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable17 in #18157

@nursoda

Copy link
Copy Markdown

I applied the PR (added the four int type definitions). That solves the issue for me.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groupshighregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nextcloud started duplicating users Users dont show after upgrade to Nextcloud 17.0.1

6 participants

@skjnldsv@kesselb@nursoda@Ases@rullzer@blizzz