Skip to content

Fix direct editing access check on Postgres - #18152

Merged
blizzz merged 1 commit into
masterfrom
bugfix/noid/direct-editing-postgres
Nov 28, 2019
Merged

Fix direct editing access check on Postgres#18152
blizzz merged 1 commit into
masterfrom
bugfix/noid/direct-editing-postgres

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 28, 2019

Copy link
Copy Markdown
Member

Postgres is returning a real boolean, so we need to cast the column value properly and not check for matching a 1

Fixes failing postgres tests that slipped in with #17625

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr changed the title Check for boolean valueFix direct editing access check on PostgresNov 28, 2019
@juliusknorrjuliusknorr added 3. to review Waiting for reviews bug labels Nov 28, 2019
@juliusknorrjuliusknorr added this to the Nextcloud 18 milestone Nov 28, 2019
@blizzz
blizzz merged commit a6ae801 into masterNov 28, 2019
@blizzz
blizzz deleted the bugfix/noid/direct-editing-postgres branch November 28, 2019 16:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@blizzz