Skip to content

Dismiss transferownership notification cancels transfer - #18359

Merged
blizzz merged 1 commit into
masterfrom
fix/18271/dismiss_transfer_ownership_notification
Dec 13, 2019
Merged

Dismiss transferownership notification cancels transfer#18359
blizzz merged 1 commit into
masterfrom
fix/18271/dismiss_transfer_ownership_notification

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#18271

As the todo states. Moving this all to a service is a bit cleaner. But my schedule lacks time.

Fixes#18271
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Dec 11, 2019
@rullzerrullzer added this to the Nextcloud 18 milestone Dec 11, 2019

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood!

This was referenced Dec 12, 2019
$notification->setUser($transferOwnership->getSourceUser())
->setApp('files')
->setDateTime($this->timeFactory->getDateTime())
->setSubject('transferownershipRequestDenied', [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, it should be already existing, but I do not see a handler for this? Less a problem of this PR though.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen said it's OK ¯\(ツ)

@blizzz
blizzz merged commit c96aa7e into masterDec 13, 2019
@blizzz
blizzz deleted the fix/18271/dismiss_transfer_ownership_notification branch December 13, 2019 14:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Transfer ownership] Incoming transfer notification can be dismissed

3 participants

@rullzer@ChristophWurst@blizzz