Skip to content

Restore old behavior allowing to set custom appstore - #18442

Merged
rullzer merged 1 commit into
masterfrom
bugfix/noid/broken_appstoreurl_config
Dec 22, 2019
Merged

Restore old behavior allowing to set custom appstore#18442
rullzer merged 1 commit into
masterfrom
bugfix/noid/broken_appstoreurl_config

Conversation

@georgehrke

@georgehrkegeorgehrke commented Dec 17, 2019

Copy link
Copy Markdown
Member

Signed-off-by: Georg Ehrke developer@georgehrke.com

@georgehrkegeorgehrke added the 2. developing Work in progress label Dec 17, 2019
@georgehrkegeorgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 17, 2019
ChristophWurst
ChristophWurst requested changes Dec 17, 2019
View reviewed changes
Comment threadtests/lib/App/AppStore/Fetcher/AppFetcherTest.php Outdated
@georgehrke

georgehrke commented Dec 17, 2019

Copy link
Copy Markdown
MemberAuthor

will squash in a sec

@georgehrke
georgehrkeforce-pushed the bugfix/noid/broken_appstoreurl_config branch from b0771e5 to 9d4cee8CompareDecember 17, 2019 14:43
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 17, 2019
@ChristophWurstChristophWurst added this to the Nextcloud 18 milestone Dec 17, 2019
@ChristophWurst

ChristophWurst commented Dec 17, 2019

Copy link
Copy Markdown
Member

do you want to backport this?

@rullzer

rullzer commented Dec 17, 2019

Copy link
Copy Markdown
Member

CI is not happy

kesselb
kesselb reviewed Dec 17, 2019
View reviewed changes
Comment threadlib/private/App/AppStore/Fetcher/CategoryFetcher.php Outdated
kesselb
kesselb reviewed Dec 17, 2019
View reviewed changes
Comment threadlib/private/App/AppStore/Fetcher/AppFetcher.php Outdated
This was referenced Dec 19, 2019
Merged
Merged
@rullzerrullzer added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 19, 2019
@rullzer

rullzer commented Dec 19, 2019

Copy link
Copy Markdown
Member

Did some fixups. Test should pass now

@georgehrke@rullzer
Restore old behavior allowing to set custom appstore
f0bef88
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@rullzer
rullzerforce-pushed the bugfix/noid/broken_appstoreurl_config branch from 389bb41 to f0bef88CompareDecember 22, 2019 14:06
@rullzer
rullzer merged commit e5d7782 into masterDec 22, 2019
@rullzer
rullzer deleted the bugfix/noid/broken_appstoreurl_config branch December 22, 2019 19:18
@georgehrke

georgehrke commented Jan 6, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

1 similar comment
@georgehrke

georgehrke commented Jan 6, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jan 6, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Jan 6, 2020

Copy link
Copy Markdown

backport to stable17 in #18694

@juliusknorr

juliusknorr commented Jan 7, 2020

Copy link
Copy Markdown
Member

Requires #18546 as well

@nickvergessen

nickvergessen commented Jan 9, 2020

Copy link
Copy Markdown
Member

This breaks the "an you update to the next major" as it assumes now that fileName is also the file name on the api endpoint.
But future-apps.json and apps.json both need to request the apps.json endpoint. They just use different request parameters.

@georgehrke

georgehrke commented Jan 9, 2020

Copy link
Copy Markdown
MemberAuthor

Fix is in #18786

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@georgehrke@ChristophWurst@rullzer@juliusknorr@nickvergessen@kesselb