Skip to content

Fix typo in occ - #18641

Merged
rullzer merged 2 commits into
nextcloud:masterfrom
HarHarLinks:patch-1
Jan 5, 2020
Merged

Fix typo in occ#18641
rullzer merged 2 commits into
nextcloud:masterfrom
HarHarLinks:patch-1

Conversation

@HarHarLinks

Copy link
Copy Markdown
Contributor

Signed-off-by: Kim Brose kim.brose@rwth-aachen.de

Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>
@gary-kimgary-kim added 3. to review Waiting for reviews bug labels Jan 3, 2020
@gary-kimgary-kim added this to the Nextcloud 18 milestone Jan 3, 2020
@gary-kim
gary-kim requested a review from rullzerJanuary 3, 2020 05:10
@gary-kim

Copy link
Copy Markdown
Member

Thank you for your contribution!

@gary-kimgary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 3, 2020
@rullzer

Copy link
Copy Markdown
Member

Ah CI fails. Could you fix the tests as well?

@gary-kim

Copy link
Copy Markdown
Member

This should do the trick

diff --git a/tests/Core/Command/User/SettingTest.php b/tests/Core/Command/User/SettingTest.php
index 7d71734334..8486e7fc3c 100644
--- a/tests/Core/Command/User/SettingTest.php
+++ b/tests/Core/Command/User/SettingTest.php
@@ -93,7 +93,7 @@ class SettingTest extends TestCase {
[['ignore-missing-user', false]],
[],
null,
- 'The user "username" does not exists.',
+ 'The user "username" does not exist.',
],
[

@gary-kimgary-kim added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 3, 2020
Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>
@HarHarLinks

Copy link
Copy Markdown
ContributorAuthor

@gary-kim that's about what I suspected, thanks for already finding it.
Let's hope this build succeeds.

@gary-kimgary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 4, 2020
@rullzer
rullzer merged commit d7fdab0 into nextcloud:masterJan 5, 2020
@welcome

welcomeBot commented Jan 5, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@rullzer

Copy link
Copy Markdown
Member

It did!

Welcome to the club @HarHarLinks

@HarHarLinks
HarHarLinks deleted the patch-1 branch January 6, 2020 00:18
@rullzerrullzer mentioned this pull request Jan 6, 2020
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HarHarLinks@gary-kim@rullzer