Skip to content

fix OCA\DAV\CalDAV\CalDavBackend search $options - #18679

Merged
rullzer merged 4 commits into
masterfrom
calDavSearch
Mar 22, 2020
Merged

fix OCA\DAV\CalDAV\CalDavBackend search $options#18679
rullzer merged 4 commits into
masterfrom
calDavSearch

Conversation

@dartcafe

@dartcafedartcafe commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

@dartcafedartcafe mentioned this pull request Jan 5, 2020
Open
@tcitworld

tcitworld commented Jan 5, 2020

Copy link
Copy Markdown
Member

Do you mind also adding a related test in apps/dav/tests/unit/CalDAV/CalDavBackendTest.php?

tcitworld
tcitworld reviewed Jan 5, 2020
View reviewed changes
Comment threadapps/dav/lib/CalDAV/CalDavBackend.php Outdated
@dartcafe

dartcafe commented Jan 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Do you mind also adding a related test in apps/dav/tests/unit/CalDAV/CalDavBackendTest.php?

erks. I am not familiar with the tests.... That's a pending thing in polls. :-)

@dartcafe

dartcafe commented Jan 5, 2020

Copy link
Copy Markdown
ContributorAuthor

OK, I tried. Tell me, if this was OK.

@tcitworld

tcitworld commented Jan 5, 2020

Copy link
Copy Markdown
Member

Added two commits to address my comments.

@georgehrkegeorgehrke added the 3. to review Waiting for reviews label Jan 6, 2020
@dartcafedartcafe mentioned this pull request Jan 15, 2020
Closed
@dartcafe

dartcafe commented Jan 21, 2020

Copy link
Copy Markdown
ContributorAuthor

As we support version 16-18, will there be a backport, so we can get rid of nextcloud/polls#747?

@dartcafe

dartcafe commented Feb 7, 2020

Copy link
Copy Markdown
ContributorAuthor

@rullzer@georgehrke
Any change to get this merged and backported, so we can release our new feature?

@skjnldsv

skjnldsv commented Feb 7, 2020

Copy link
Copy Markdown
Member

Please rebase :)

@skjnldsv

skjnldsv commented Feb 7, 2020

Copy link
Copy Markdown
Member

/backport to stable18

@skjnldsv

skjnldsv commented Feb 7, 2020

Copy link
Copy Markdown
Member

/backport to stable17

@skjnldsv

skjnldsv commented Feb 7, 2020

Copy link
Copy Markdown
Member

/backport to stable16

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2020
@skjnldsvskjnldsv added this to the Nextcloud 19 milestone Feb 7, 2020
@dartcafe

dartcafe commented Mar 14, 2020

Copy link
Copy Markdown
ContributorAuthor

any doa? Still waiting for seeing this in a release.

dartcafeand others added 4 commits March 22, 2020 14:24
@dartcafe@rullzer
fix OCA\DAV\CalDAV\CalDavBackend search $options
65c5910
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe@rullzer
Added test testSearch
b0fbba0
Signed-off-by: dartcafe <github@dartcafe.de>
@tcitworld@rullzer
Add extra test case to exclude by timerange
01db6d4
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld@rullzer
Add check that DateTime parameters are of correct type
42dde6d
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@rullzer
rullzer merged commit 9956922 into masterMar 22, 2020
@rullzer
rullzer deleted the calDavSearch branch March 22, 2020 18:39
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 22, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 22, 2020

Copy link
Copy Markdown

backport to stable18 in #20102

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 22, 2020

Copy link
Copy Markdown

The backport to stable17 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 22, 2020

Copy link
Copy Markdown

The backport to stable16 failed. Please do this backport manually.

This was referenced Mar 26, 2020
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgehrkegeorgehrkegeorgehrke approved these changes
@tcitworldtcitworldtcitworld approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

6 participants

@dartcafe@tcitworld@skjnldsv@georgehrke@rullzer@MorrisJobke