Uh oh!
There was an error while loading. Please reload this page.
Test: Run phan with github workflows - #18680
Closed
kesselb wants to merge 3 commits into
Closed
Conversation
kesselbforce-pushed
the
enh/hello-phan
branch
3 times, most recently
from
June 25, 2020 23:14
1435e76 to
e8bd737CompareMorrisJobke
commented
Jul 6, 2020
Member
Nice ... was about to resurrect the one in drone: a987f80 but this then can go. |
kesselbforce-pushed
the
enh/hello-phan
branch
2 times, most recently
from
July 6, 2020 20:10
737ad18 to
19297eaCompareContributorAuthor
Changed the level back to critical. Still some warnings to fix. Also SqlInjectionCheckerPlugin is commented. Not sure how to update it. |
kesselbforce-pushed
the
enh/hello-phan
branch
9 times, most recently
from
July 8, 2020 12:47
aabd5bd to
a8cd2cfCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MorrisJobke
commented
Sep 16, 2020
Member
I guess the fixes from here are fine, but the Phan part can go - see #22883 |
MorrisJobke
commented
Sep 16, 2020
Member
Let me rebase this. |
MorrisJobkeforce-pushed
the
enh/hello-phan
branch
from
September 16, 2020 14:08
08c6868 to
afb2d8dCompareSigned-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
https://github.com/phan/phan/wiki/Generic-Types#indicating-a-method-creates-an-instance-of-the-passed-in-class-name Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
MorrisJobkeforce-pushed
the
enh/hello-phan
branch
from
September 16, 2020 14:09
afb2d8d to
04c1222CompareMorrisJobke
commented
Sep 16, 2020
Member
Let's extract them step by step in separate PRs. |
This was referenced Sep 16, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Kesselberg mail@danielkesselberg.de