Skip to content

A pending shares overview - #18707

Merged
rullzer merged 2 commits into
masterfrom
enh/pending_shares_overview
Jan 7, 2020
Merged

A pending shares overview#18707
rullzer merged 2 commits into
masterfrom
enh/pending_shares_overview

Conversation

@rullzer

@rullzerrullzer commented Jan 7, 2020

Copy link
Copy Markdown
Member

Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

As noticed by @tobiasKaminsky
If you now press X on a share. It just doesn't show.

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

@rullzer
A pending shares overview
fbed6a3
Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 18 milestone Jan 7, 2020
@juliusknorr

juliusknorr commented Jan 7, 2020

Copy link
Copy Markdown
Member

@rullzer Pushed a commit for the frontend part. For now I've added a separate "pending shares" list where the user can either accept or reject them.

@rullzer

rullzer commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

@juliushaertl mmm it isn't working for me... I don't see the request in the network tab as well..

@juliusknorr
juliusknorrforce-pushed the enh/pending_shares_overview branch from 1db494a to 87ea79aCompareJanuary 7, 2020 12:15
@rullzer

rullzer commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

Awesome!

Only thing. The details and show in folder in the '...' are kind of broken now...

@juliusknorr
juliusknorrforce-pushed the enh/pending_shares_overview branch from 87ea79a to a3a510cCompareJanuary 7, 2020 12:32
@juliusknorr

juliusknorr commented Jan 7, 2020

Copy link
Copy Markdown
Member

Only thing. The details and show in folder in the '...' are kind of broken now...

Fixed 😉

@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 7, 2020
@wiswedel

wiswedel commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

@juliushaertl Can you provide a screenshot please?

@tobiasKaminsky

tobiasKaminsky commented Jan 7, 2020

Copy link
Copy Markdown
Member

image

Behind "Name" is 123.txt, which is barely readable.

@tobiasKaminsky

tobiasKaminsky commented Jan 7, 2020

Copy link
Copy Markdown
Member

(might be because of my test system, but I did not got any notification (red alarm bell)?
I thought I received one on plain master?

@juliusknorr

juliusknorr commented Jan 7, 2020

Copy link
Copy Markdown
Member

Behind "Name" is 123.txt, which is barely readable.

Unrelated, please open a separate issue.

(might be because of my test system, but I did not got any notification (red alarm bell)? I thought I received one on plain master?

Do you have the notifications app enabled and did you wait for some time as the web ui just polls regularly for new notifications.

@rullzer

rullzer commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

(might be because of my test system, but I did not got any notification (red alarm bell)?
I thought I received one on plain master?

This doesn't touch any notification code.
So lets review what this fixes and get it in and then we look at other things ;)

@rullzerrullzer mentioned this pull request Jan 7, 2020
Merged
1 task
@tobiasKaminskytobiasKaminsky mentioned this pull request Jan 7, 2020
Closed
@tobiasKaminsky

tobiasKaminsky commented Jan 7, 2020

Copy link
Copy Markdown
Member

👍 working otherwise

@jancborchardt

jancborchardt commented Jan 7, 2020

Copy link
Copy Markdown
Member

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

@juliusknorr

juliusknorr commented Jan 7, 2020

Copy link
Copy Markdown
Member

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

If we schedule some time for that in 19, I think this should be doable with not to much effort. Just nothing we can implement properly 1 1/2 weeks before the actual release.

@rullzer

rullzer commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

For now I would go for a new section in the sharing section. But for 19 we should look into unifying this with the deleted shares. @nextcloud/designers

:( I heard this often before … yes I guess it has to be done like this for lack of time, but I’m not happy as I doubt it will in fact be fixed for 19. The spec has been there for ages at #2192

I know what you mean. But the alternative is that we have nothing right now. ;)

@juliusknorr@rullzer
Add pending share list to frontend
445274c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enh/pending_shares_overview branch from a3a510c to 445274cCompareJanuary 7, 2020 18:36
@rullzer

rullzer commented Jan 7, 2020

Copy link
Copy Markdown
MemberAuthor

Fixed the tests.
Lets do this.

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2020
@rullzer
rullzer merged commit 4d1f710 into masterJan 7, 2020
@rullzer
rullzer deleted the enh/pending_shares_overview branch January 7, 2020 19:55
john6361
john6361 approved these changes May 14, 2025
View reviewed changes

@john6361john6361 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tq

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@tobiasKaminskytobiasKaminskyAwaiting requested review from tobiasKaminsky
@kesselbkesselbAwaiting requested review from kesselb
@gary-kimgary-kimAwaiting requested review from gary-kim
@wiswedelwiswedelAwaiting requested review from wiswedel
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
1 more reviewer
@john6361john6361john6361 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: sharing

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer@juliusknorr@wiswedel@tobiasKaminsky@jancborchardt@john6361