Use paginated search for contacts

[juliusknorr]

This PR drastically improves the performance of searching for sharees when the system addressbook contains a lot of users. Without it all matching contact entries would be queried from the database for both SHARE_TYPE_REMOTE and SHARE_TYPE_EMAIL which led to quite bad performance when searching with queries that matched a lot of entries (1-3 characters)

[nickvergessen]

The problem is, if you e.g. match the local domain, you will get all system address book entries.
But they are skipped with the first if in the loop, but also no further contacts will be found, although you would have matches.

[juliusknorr]

Contacts from other addressbooks should still be found, since the search is executed with the limit on each addressbook individually: https://github.com/nextcloud/server/pull/18816/files#diff-905974f5907f69fe7586a80ea67117a6L48

[juliusknorr]

Stil concerns @nickvergessen ?

[nickvergessen]

Lets try it

[nickvergessen]

Needs a rebase

[MorrisJobke]

Needs a rebase

Done.

[blizzz]

CI looks quite red

[juliusknorr]

Aw, isset is no function so using \isset was failing 🙈

[nickvergessen]

An exception occurred while executing "SELECT c.carddata, c.uri FROM oc_cardsc WHERE c.id IN (SELECT DISTINCT cp.cardid FROM oc_cards_propertiescp WHERE (cp.addressbookid = ?) AND ((cp.name = ?) OR (cp.name = ?)) AND (cp.value COLLATE utf8mb4_general_ci LIKE ?) LIMIT 10)" with params ["1", "EMAIL", "FN", "%tes%"]:\n\nSQLSTATE[42000]: Syntax error or access violation: 1235 This version of MySQL doesn"t yet support "LIMIT & IN/ALL/ANY/SOME subquery"

:(

[J0WI]

current syntax

SELECT`c`.`carddata`, `c`.`uri`FROM`oc_cards``c`WHERE`c`.`id`IN (
SELECT DISTINCT`cp`.`cardid`FROM`oc_cards_properties``cp`WHERE (`cp`.`addressbookid`= ?)
AND ((`cp`.`name`= ?)
OR (`cp`.`name`= ?))
AND (`cp`.`value` COLLATE utf8mb4_general_ci LIKE ?)
LIMIT10
);

@nickvergessen AFAIK you can just use an additional dummy subquery as a workaround. Can you try something like:

SELECT`c`.`carddata`, `c`.`uri`FROM`oc_cards``c`WHERE`c`.`id`IN (
SELECT`cardid`FROM (
SELECT DISTINCT`cp`.`cardid`FROM`oc_cards_properties``cp`WHERE (`cp`.`addressbookid`= ?)
AND ((`cp`.`name`= ?)
OR (`cp`.`name`= ?))
AND (`cp`.`value` COLLATE utf8mb4_general_ci LIKE ?)
LIMIT10
)
AS compatlayer
);