Uh oh!
There was an error while loading. Please reload this page.
[stable17] relax strict getHome behaviour for LDAP users in a shadow state - #18884
Merged
Conversation
skjnldsv
approved these changes
Jan 14, 2020
Merged
rullzer
commented
Jan 21, 2020
Member
CI fails |
This comment has been minimized.
This comment has been minimized.
blizzzforce-pushed
the
backport/17717/stable17
branch
from
February 27, 2020 22:51
85385f2 to
c55c988Compareblizzz
commented
Feb 27, 2020
MemberAuthor
were just phpunit version related incompatibilities |
skjnldsv
approved these changes
Feb 28, 2020
juliusknorr
commented
Feb 28, 2020
Member
@blizzz Please squash the fixups. 😉 |
juliusknorr
approved these changes
Feb 28, 2020
* simplifies deletion process * less strange behaviour when looking up home storage (as long as it is local) * thus could enable transfer ownerships after user went invisible on ldap backport of #17717 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> decouple userExists from userExistsOnLDAP check allows to mark users as offline right away, avoids a gap of being not a user and causing weird side effects Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> adjust tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> remove superfluous tests - user_ldap is not exposed to public api, it is always behind ldap_proxy - this is too much for a unit test - integration tests cover userExists implicitly Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> ensure that only valid group members are returned Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
backport/17717/stable17
branch
from
February 28, 2020 17:05
c26792b to
2056758Compare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #17717