Skip to content

fix multiselect actions for files - #18913

Merged
rullzer merged 2 commits into
masterfrom
bugfix/fix_multiselect_actions
Jan 24, 2020
Merged

fix multiselect actions for files#18913
rullzer merged 2 commits into
masterfrom
bugfix/fix_multiselect_actions

Conversation

@GretaD

Copy link
Copy Markdown
Contributor

fixes#18871

Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaDGretaD added bug design Design, UI, UX, etc. labels Jan 15, 2020
@rullzerrullzer added this to the Nextcloud 19 milestone Jan 15, 2020
@rullzer

Copy link
Copy Markdown
Member

/backport to stable19

@jancborchardt

Copy link
Copy Markdown
Member

It doesn’t seem to be the right element as it’s not the whole width.

What seems to work is:

thead {
position: sticky;
top: 94px;
}

Can you confirm?

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment ^

@jancborchardt
jancborchardt self-requested a review January 15, 2020 23:45

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment ^

@GretaD

GretaD commented Jan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

It doesn’t seem to be the right element as it’s not the whole width.

What seems to work is:

thead {
position: sticky;
top: 94px;
}

Can you confirm?

Position sticky at thead is already there(see below). Changing the #headerName does the trick, am i missing something..?

/* Multiselect bar */
table.multiselect thead {
@include position('sticky');
top: 94px;

… other headers
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
Member

Time for review, @rullzer had issues with Firefox when testing this shortly before 18.0.0 but I cannot reproduce them actually. Works fine for me in Firefox/Chromium. Please test @nextcloud/designers

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
rullzer merged commit a378071 into masterJan 24, 2020
@rullzer
rullzer deleted the bugfix/fix_multiselect_actions branch January 24, 2020 09:05
@rullzer

Copy link
Copy Markdown
Member

/backport to stable18

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #19108

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiselect bar is not sticky anymore

6 participants

@GretaD@rullzer@jancborchardt@juliusknorr@ChristophWurst@skjnldsv